qmcpack icon indicating copy to clipboard operation
qmcpack copied to clipboard

OperatorEstBase DataLocality modes

Open ye-luo opened this issue 3 years ago • 1 comments

Is your feature request related to a problem? Please describe.

  1. Why OperatorEstBase::data_locality_ is not const?
  2. Should OperatorEstBase::myName const and set via constructor?
  3. SpinDensityNew implements copy constructor based on data_locality_ state but MomentumDistribution implements similar things in clone()

Please consolidate the design and add documentation.

ye-luo avatar Sep 23 '21 23:09 ye-luo

I think 1 and 2 are probably correct. I'm working through my too clever copy constructor in 3 but I'm not sure that will put the logic in clone.

PDoakORNL avatar Nov 02 '21 13:11 PDoakORNL