Kwon Taeheon comments

Results 6 comments of


                                            Kwon Taeheon

[Improvement] Correct handling of in ECDSA algorithms in StaticSignKeyValidator.java

Hi! @justinmclean Can I take this issue?

require: fix invalid examples in doc comments (codegen)

@ccoVeille Thanks, I also felt the code was a bit messy, so I tried to simplify it further. Regarding your comment about tests: since this is only used for code...

require: fix invalid examples in doc comments (codegen)

Is there anything more I should do, or anything I might be misunderstanding?

require: invalid examples from doc comments as functions don't return bool

Hello! I was wondering if this issue has already been resolved. Could you please confirm? Thank you! https://github.com/stretchr/testify/pull/1675

require: invalid examples from doc comments as functions don't return bool

I'd like to contribute to resolving this issue! In my opinion, even though `assert` and `require` are similar, they have different responsibilities. Wouldn't it be better to maintain separate documentation...

require: invalid examples from doc comments as functions don't return bool

@brackendawson Sorry for the late reply. 😅 I’m not sure if I expressed my point clearly before. My view is that the responsibility of 'require' is to fail immediately, not...