JunyanHuo
JunyanHuo
Hi @DanRyanIrish, as we have discussed in our project meetings, below are the issues we encountered and may need further discussions with others in the community: The issue is mainly...
@DanRyanIrish, Secondly, we also encountered some issues around the propagate method: it ignores the mask of the objects that are passed in, and still takes into account the uncertainties of...
Notes for the current stage of development: 1, The 'TypeError: None is not a valid Unit' occurs whenever an NDCube/NDData object with a unit enters the propagate method. Their values...
> Hi @PCJY. I've edited your mask discussion in the PR description. I've created a table for all the scenarios for determining the result of adding the masked data. Can...
Hi @DanRyanIrish , I have pushed four new commits. Any suggestions would be appreciated. 1, I added three different conditional blocks for the three with-mask scenarios, and to set the...
Test Scenarios with mask - NDCube has mask but NDData does not - NDCube does not have mask but NDData does - Both NDCube and NDData have mask handle_mask is...
Hi @DanRyanIrish I have just implemented the method more, finished adding tests for the method. Apologies for the delay. I also handled units by keeping the unit the same (which...
Hi @DanRyanIrish , just so you know, the last three commits are the latest ones I made. Thank you.
Hi @DanRyanIrish , I have finished debugging the tests (with the latest four commits): 1, There were some errors in the fixtures I used, so I fixed them. 2, I...
Hi @DanRyanIrish , thanks for your review and bringing up the single-Boolean case issue. In my latest commit, there a few new changes addressing the single-Boolean-True mask value test case,...