PB

IMO, the code maintainability could be improved by removing the duplicate code existing for the two implementations. I would factor out and share the common code: 1. Common wx include...

Sorry for asking again: Do we really really need all those changes in the lunasvg sources (i.e., is that different from all other 3d party libraries)? This can make updating...

Last time this was [discussed](https://github.com/wxWidgets/wxWidgets/issues/24346), @MaartenBent wrote: > What I remember from upgrading to 5.0.0 is that the upgrade to 5.0.1 will be the most difficult one because there are...

As I wrote on forum, this: 1. Can be reproduced in the unmodified listctrl sample. 2. May be caused by hottracking drawn over the item including rulers with the same...

Did you change the parameter type from `wxDC` to `wxReadOnlyDC` in the overriden method? https://github.com/wxWidgets/wxWidgets/blob/d557e926b187afe29e37847ba6652da326e1bba7/docs/changes.txt#L224-L227 But perhaps that should get caught by the compiler when using the `override` attribute (assuming...

IMO, this is a bit tricky. Even if you read the changelog carefully, you may not get all the implications (i.e., remember where a `wxDC` is used in an overriden...

But how would that help with this issue, i.e., the method with a new signature being called by wxWidgets? Would this not actually hide the problem since this would compile...

> OK. How about using **final** then? Well, I guess that may work and as much people hate having their builds broken, it may be better than their overriden methods...

> Also it would be very useful to have something like `bool IsDark` in `wxMenuItem` so we would know exactly what images to assign to the menu item (dark or...

IMO, it is not ignored, it is just an another issue with the limitations of the native menu control or in wxWidgets. It does not make any sense to mix...