P-E-P

Results 89 comments of P-E-P

I've been reading the discussion about [`#[start]`](https://github.com/rust-lang/rust/issues/29633) and I found no mention of envp ?

You're right. We'll need to inherit from `ExternalItem` in order to return a function from this function but it'll be probably harder than expected. At first I thought this would...

> I'm not a fan of the NodeId duplication, I'll take a deeper look in the upcoming days to be sure there's no way around. > > Otherwise, it looks...

> Rebased, now it should be able to merge Not entirely sure, sometimes the queue is doing weird things and we have to merge by hand. Let's try again.

> not sure if pr #2980 fixes this? Yes @badumbatish , once PR #2980 is fixed it will also fix this issue.

I'm unsure this should be done at this stage of the compiler, this surely is simpler after a bit of desugaring. Have you taken a look at rustc's way of...

@dme2 What is the current state of this PR ? From what I've read it seems like there is only a minor format issue ?

Closed in favor of #3055 (This is exactly the same PR with proper code format). Thank you for the initial work!

> optional: Add [[nodiscard]] Isn't this C++17 ? Won't it break with 4.8 ?

@CohenArthur Should we close this PR ?