Zuobai Zhang issues

Results 3 issues of


                                            Zuobai Zhang

Shape mismatch error in the GraphConv layer

https://github.com/DeepGraphLearning/torchdrug/blob/5bf0a505282c5e93fbf92a91ace8fe40ecc13d4c/torchdrug/layers/conv.py#L154-L174 In the message_and_aggregate() method of GraphConv class, the edge list is concatenated with self-loops while the edge input isn't. This will cause a shape mismatch error in this line....

bug

Mel滤波器中的实现错误

https://github.com/ichn-hu/Speech-Recognition-Via-CNN/blob/0ba990a6d3dc9ecc77a1f0a75a95d475b7a5a1b8/utils.py#L293-L302 这里的Mel滤波器实现参考的应该是https://haythamfayek.com/2016/04/21/speech-processing-for-machine-learning.html ，是有问题的。Mel滤波器是连续频率下的三角滤波器，转换成离散频率时我们应在对应的离散点采样，而不是把三角滤波器的顶点取整后重新计算滤波器的值。

Cycle checking issue in check_inheritance function in PA4

您好，感谢您的代码分享！在check_inheritance函数中似乎有一个问题，判断是否成环不能仅判断一个节点是否最终会返回到自己。比如，D : A, A : B, B : C, C : A的情况，如果从D开始判断的话会死循环。 https://github.com/afterthat97/cool-compiler/blob/d83175f723d3469527b2c63d20ebe9f12c653b46/assignments/PA4/semant.cc#L315-L337