Himanshu Mishra

Results 122 comments of Himanshu Mishra
trafficstars

Awesome! I don't think the commit solves the problem, since it's still returning a static string. It should somehow return a more suitable "name" for the local site being served.

@solid-state58 See you tomorrow on the Zoom link! Can you send me an email at [email protected] so that I can send you a calendar invite?

@awanlin I see the PR is not merged yet. > how getting automation in place will make upgrades much easier. This sounds like a good idea to talk about anyway....

That sounds exactly right @heyLu ! Would love to get a glimpse even if it isn't open source. Otherwise, next month!

Thanks for the detailed report @rodmachen ! Reproducible on the master branch of `backstage/backstage` as well by removing `yarn.lock` and running `yarn install` again. The reason why it's not reproducible...

I think so too. [email protected].* is using the correct version of normalize-url v4 which is not broken on Safari. https://github.com/IonicaBizau/parse-url/blob/5.0.6/package.json#L35

Re-opening since plugin suggestion issues are now exempt from [stalebot](https://github.com/backstage/backstage/blob/18f7345a6c29dcfccef7df081b1708f2bf8f62ff/.github/stale.yml#L9).

@cjlee01 Looks like the microsite build was fixed. Please rebase https://github.com/backstage/backstage/pull/24499