Robin comments

Results 220 comments of


                                            Robin

feat(useIntervalFn): add controls to callback function

This change is breaking. We should hide this behind an option https://vueuse.org/guidelines.html#when-to-provide-a-controls-option

feat(useIntervalFn): add controls to callback function

ohhh, you are right.

`nypm info <pkg>`

I'm opening this thread to discuss some questions I will update this thread as I go along, so please feel free to comment. I'll ping you when I've finished planning...

`nypm info <pkg>`

Open Questions: - If we are not using the pm and instead fetch regristries directly, how do we authenticate for private packages? We cant use the pms auth I guess

fix: (n-dialog) props types fixes and new async example

Hey, thank you for your PR. Can you briefly explain why this is necessary? Can't you just pass the ref value? Then everything is reactive, isn't it?

fix: (n-dialog) props types fixes and new async example

I think you dont need to change the types of the props. You should change the types of the composable options

fix: (n-dialog) props types fixes and new async example

> > You should change the types of the composable options > > Which of composables? > > > I think you dont need to change the types of the...

feat!: simplify `useAsyncData()` handler signature

> Let's use a future flag to make the breaking change for v5 Can you help me with that? 😅

refactor(nuxt): use AST-aware function key injection

I dont think I can help much with the review, but if necessary, I could test it in 1 or 2 projects to check that backward compatibility is ensured.

refactor(nuxt): use AST-aware function key injection

I have tested some [projects that use `keyedComposables`](https://github.com/search?q="keyedComposables"+path%3A%2F(%5E%7C%5C%2F)nuxt%5C.config%5C.ts%24%2F&type=code). Looks good so far. I did not encounter any issues.