copilot

copilot copied to clipboard

If a.git directory exists in the plugin directory it will test every .git sub-directory as a possible plugin.

2

The [get_plugins](https://github.com/OpenInternet/copilot/blob/a3f67665b84ce1e897ec1f87f835de8dc4d344d6/copilot/utils/plugin.py#L15-L25) function will iterate through the various levels of the .git directory unnecessarily.. This will need to be addressed before we can implement issue #124

seamustuohy

The watch_config script should directly query plugins to make configuration easier.

1

The [watch_config](https://github.com/OpenInternet/co-pilot/blob/e832310e7001fa9531ab888d35e1b01551fd7eef/bin/watch_config#L42-L43) script currently has the config files to watch, and their corresponding hard coded.It should directly query plugins to make adding a file to watch for a new plugin...

seamustuohy

The watch_config script currently uses [a hardcoded directory name](https://github.com/OpenInternet/co-pilot/blob/e832310e7001fa9531ab888d35e1b01551fd7eef/bin/watch_config#L44-L45) to determine where config files should be stored. In the future it should get these from environment variables. This will make...

seamustuohy

The current [validation method](https://github.com/OpenInternet/co-pilot/blob/master/copilot/models/config.py#L270-L284) for the profile config object only validates the existence of the name object within the info section. This function should be checking for more of the...

seamustuohy

The current__init__ function simply [re-raises value errors](https://github.com/OpenInternet/co-pilot/blob/e832310e7001fa9531ab888d35e1b01551fd7eef/copilot/models/profile.py#L59-L64) that are found when adding a rule. This should be changed to either correct the error or should not be contained within a...

seamustuohy

The current add_rule function simply [re-raises value errors](https://github.com/OpenInternet/co-pilot/blob/e832310e7001fa9531ab888d35e1b01551fd7eef/copilot/models/profile.py#L89-L94) that are found when adding a rule. This should be changed to either correct the error or should not be contained within...

seamustuohy

[get_profile_status](https://github.com/OpenInternet/co-pilot/blob/e832310e7001fa9531ab888d35e1b01551fd7eef/copilot/models/profile.py#L17-L49) currently uses a [bare-except.](https://github.com/OpenInternet/co-pilot/blob/e832310e7001fa9531ab888d35e1b01551fd7eef/copilot/models/profile.py#L21-L26) This should be replaced by proper exception handling. Testing needs to be done to see what exception types are raised when the trainer object does...

seamustuohy

The try/except stanza that sets the status of the [current_ap](https://github.com/OpenInternet/co-pilot/blob/e832310e7001fa9531ab888d35e1b01551fd7eef/copilot/models/trainer.py#L33-L37) in [get_ap_status](https://github.com/OpenInternet/co-pilot/blob/e832310e7001fa9531ab888d35e1b01551fd7eef/copilot/models/trainer.py#L30-L44) should actually evaluate if CoPilot is providing an access point instead of simply looking for if the AP...

seamustuohy

[get_ap_status](https://github.com/OpenInternet/co-pilot/blob/e832310e7001fa9531ab888d35e1b01551fd7eef/copilot/models/trainer.py#L30-L44) currently uses a [bare-except](https://github.com/OpenInternet/co-pilot/blob/e832310e7001fa9531ab888d35e1b01551fd7eef/copilot/models/trainer.py#L36). This should be replaced by proper exception handling. Testing needs to be done to see what exception types are raised when the trainer object does...

seamustuohy

The [profile_applied interface](https://github.com/OpenInternet/co-pilot/blob/e832310e7001fa9531ab888d35e1b01551fd7eef/copilot/views/profile.py#L124-L139) and its [corresponding template](https://github.com/OpenInternet/co-pilot/blob/e832310e7001fa9531ab888d35e1b01551fd7eef/copilot/templates/profile_applied.html) are not currently used and should be removed.

seamustuohy