cyphal.rs icon indicating copy to clipboard operation
cyphal.rs copied to clipboard

Consolidate logic between std_vec and heap_based session implementations.

Open davidlenfesty opened this issue 3 years ago • 1 comments

Specifically the update function, how it's implemented in HeapSessionManager is much more readable and clear, and we can likely consolidate the logic into a single place.

At the minimum update StdVecSessionManager to mimic the style.

davidlenfesty avatar Dec 11 '21 01:12 davidlenfesty

I thought on this as well. I think we can go with HeapSessionManager. This has the same logic with some improvements. It uses the alloc crate, so it can be used in no_std and std environments.

I think a more contrast implementation would be having more static memory usage.

teamplayer3 avatar Dec 13 '21 19:12 teamplayer3