cyphal.rs icon indicating copy to clipboard operation
cyphal.rs copied to clipboard

Set up continuous integration

Open pavel-kirienko opened this issue 4 years ago • 5 comments

The CI is nonexistent which should be fixed sooner rather than later.

pavel-kirienko avatar Oct 13 '21 09:10 pavel-kirienko

Done in #84, also added protections to v1 branch to enforce this as we work.

davidlenfesty avatar Oct 13 '21 16:10 davidlenfesty

Speaking of branches, should we not move all v1 work to master and branch out the current implementation to v0? The v0 implementation has always been experimental so we certainly won't upset anybody by doing so.

pavel-kirienko avatar Oct 13 '21 16:10 pavel-kirienko

I merged #84 but won't close this issue until we have either rustfmt or clippy integrated.

As far as branches are concerned, I'm fine with placing this work on master. I didn't want to step on anyone's toes because I was never sure what the exact status of v0 support was.

davidlenfesty avatar Oct 14 '21 04:10 davidlenfesty

(Mostly just putting my thoughts here so I don't forget)

I would like to do automated integration/interoperability tests with at least one other implementation. Likely the easiest way to do this would be to add some tests (behind a feature flag such as "yakut_tests" so that they don't get triggered on some random person's machine that isn't set up for it) that are meant to run in a docker container with access to yakut and a VCAN device. Then we can just call yakut commands for our tests, and won't have to maintain large amounts of non-rust code for our integration tests.

davidlenfesty avatar Mar 27 '22 02:03 davidlenfesty

Yakut may not be the optimal choice for this task because it is mostly built for interactive use by a human rather than complex automation. A simple Python script based on PyUAVCAN might be a better option.

pavel-kirienko avatar Mar 27 '22 02:03 pavel-kirienko