Omnikar comments

Results 93 comments of


                                            Omnikar

[Feature] Allow checking out specific commits in log view

@extrawurst I could try to implement it, what keybind should it have?

[Feature] Allow checking out specific commits in log view

Yeah sorry, I've been busy. I should have time now.

[Feature] Allow checking out specific commits in log view

@extrawurst What is `scope_time!`?

[Feature] Allow checking out specific commits in log view

Add keybind to checkout commit in log view

How do I get the keybind to appear in this bar at the bottom?

For removing empty scratch buffers, check that a buffer is empty rather than unmodified

Actually, I feel like we should instead be marking buffers created from stdin as modified, since they contain unsaved content and should be protected from being lost, right?

For removing empty scratch buffers, check that a buffer is empty rather than unmodified

> I'm not sure how useful it would be (for example for undoing) but it's intuitive to me that the text from stdin would be a revision in the history...

For removing empty scratch buffers, check that a buffer is empty rather than unmodified

How should I go about marking stdin scratch buffers as modified? Create them as an empty scratch buffer then add the text given by stdin as a change?

For removing empty scratch buffers, check that a buffer is empty rather than unmodified

In the `new_file_from_stdin` function in `helix_view::editor`, creating an empty `Document` using `Document::default()` rather than the current document creation via `Document::from` does not take the `encoding` value, and the `.set_encoding` method...

For removing empty scratch buffers, check that a buffer is empty rather than unmodified

> I think you should just be able to use `doc.line_ending = encoding`, no? `encoding` is of type `&encoding::Encoding`. `Document::set_encoding` takes type `&str`. `Document::line_ending` is of type `helix_core::line_ending::LineEnding`.