h0ps

> Overall the code looks nice and the changes make sense. I left some comments there and plan to run some tests when they are addressed. I think I have...

> > 2. How does the user join to a LoRaWAN 1.0.x NS if using the 1.1 binary? That is not possible at the moment. I could however add e.g....

@jia200x Should I rather prioritize stack usage or coverage ? E.g. should I leave a struct member only needed in LoRaWAN 1.1 to increase coverage with `if(IS_USED(...` or remove it...

> Ideally members should be removed from the struct if they are not used. Although this rules out if(IS_USED), you can always write getters/setters that map to no op if...

> Last round of (style) comments. Otherwise, I will proceed testing it against a Chirpstack instance. > > From the Kconfig side I'm also not sure how to deal with...

@jia200x Do you need anything else to start testing?

> > @jia200x Do you need anything else to start testing? > > Time smile > > I will give it a look during the week All good :) Just...

> while testing, I realized the netif commands are not implemented in sc_gnrc_netif (so, you cannot e.g set the join key from the shell). This is important, since RIOTCtrl uses...

> after flashing again, I get these messages from the join server: > > ``` > DevNonce is too small > ``` > > Any ideas? Yes this is due...

> > after flashing again, I get these messages from the join server: > > ``` > > DevNonce is too small > > ``` > > > > >...