Olivier Lenoir

Results 8 comments of Olivier Lenoir

Both pull requests are link to the same implementation of mip install from GitLab. - https://github.com/micropython/micropython-lib/pull/816 - https://github.com/micropython/micropython/pull/13791 Signed-off-by: Olivier Lenoir [email protected] ------------------------------------------------------- https://github.com/micropython/micropython-lib/pull/816 Modify _rewrite_url() to allow mip install...

@jimmo , I've aggregated both topics into one. I've also added a _deps_ example with _gitlab:_. Let me know if you valid the documentations modification.

> Thanks for updating! Please squash the commits down to a single commit (or if you want, one to the code and one to the docs).

@jimmo, I've fix the extra :: after github. Regarding your demand to squash down to a single commit, I'm not certain how to do, it's my first real contribution to...

> You PR seems completely messed up, since it contains all the STATIC->static changes. Did you rebase your branch before changing the STATIC case locally? Then I'm trying to rebase...

@jimmo I think it's now correct, thanks to your help: [https://github.com/jimmo/git-and-micropython](https://github.com/jimmo/git-and-micropython). What is the next step, if any?

Both pull requests are link to the same implementation of mip install from GitLab. - https://github.com/micropython/micropython-lib/pull/816 - https://github.com/micropython/micropython/pull/13791 Signed-off-by: Olivier Lenoir [email protected] ------------------------------------------------------- https://github.com/micropython/micropython-lib/pull/816 Modify _rewrite_url() to allow mip install...

@jimmo I think this PR is right. What's the next step, if any?