Oliver Joseph Ash

Results 333 comments of Oliver Joseph Ash

For context, I want to use the difference to apply a patch to another kind of object.

@yakov116 That would work, although it's less discoverable.

> Is it possible that there’s no path to that page? Isn't it just as simple as replacing the commit param in the URL with the following? - For commits,...

On the base branch/commit I think? (The existing "view file" points to the head branch/commit.)

I found a decent explanation of the problem in [another library (which also has this issue), `react-tags`](https://github.com/i-like-robots/react-tags): https://github.com/i-like-robots/react-tags/issues/94 Extracting from there and the links within, here's how I understand the...

> I'm not sure if I follow along with how it changes the behavior based on the environment. Can you elaborate more? Preferably with code examples? Thanks! Does this help?...

My workaround for now is to always enable `requestHandler`, and to conditionally enable Sentry, optionally provide the Sentry DSN + `enable` option. This at least gives us consistent behaviour.

@HazAT I didn't see any response to my last comment, so I don't think this is solved? If so can we re-open?

Currently, when the domain receives an error, we forward the error to Express' error handling middleware by calling `next` with the error as an argument: https://github.com/getsentry/sentry-javascript/blob/913eafc47c7c9ee3bb481615c5ad4016707ce926/packages/node/src/handlers.ts#L236 I think we should...