Oliver Joseph Ash

Results 333 comments of Oliver Joseph Ash

Please could you provide a full reduced test case? It might be your `fp-ts` version—this library currently uses an older version.

@bradzacher > Specifically you're looking for these cases: I think there are a few more cases to consider. I tried to demonstrate these in my tests. For example, function return...

To make sure we're all on the same page, this is what I meant by "function annotation" and "inline annotations". Function annotation: ```ts const f: (n: number) => number =...

> How does the rule handle nested functions. For example: I think this rule should only check for duplicate type annotations between direct pairs, where a function has both a...

My bad—you're right! > is it just that find all / rename isn't working as expected? It's just that. Out of interest, if the contextual type does flow through as...

> Is there a type system observation of the problem you're describing Actually, I think this might be one? ```ts declare const identity: (x: T) => T; type User =...

@RyanCavanaugh Thanks for clarifying and updating this issue. Do you have any thoughts with regards to the behaviour [I described for excess properties](https://github.com/microsoft/TypeScript/issues/50860#issuecomment-1253428857)? Is this something that could be changed/fixed...

Looks like retry only works if there is an exception (https://github.com/webdriverio/wdio-sync/blob/32bf88aa30373e50529a2b9cae58573c0a5e6a07/index.js#L472) so presumably `expect` is not throwing? Should it throw? Looking at how Jasmine works, it looks like `expect` is...

I'm not quite sure how to do that, though. 😒 If I understand correctly, this adapter invokes `executeSync` which is responsible for doing the retry, but I'm not sure where/how...