Oliver Layer
Oliver Layer
From the log output, it seems like the failing CI jobs are not related to this change. Correct me if I am wrong though. Should I rebase (in case the...
Rebased to current main, now waiting for the CI approval again :)
> My point is that _if the path cannot be written to_, the error happens when opening the file, not later on. That is true. I guess the question is...
> A compromise would be to add a dedicated option in `S3Options`, but of course the optimization would only benefit those users that enable the option. We can do that....
I added a `sanitize_bucket_on_open_` flag to the `S3Options`, adjusted the logic and also instantiated tests with this flag enabled. I guess the Python bindings can be tackled in a separate...
> A minor question: would single-part only send during closing? Yes, we only issue the `PutObject` request if we close the stream.
I also merged main into this branch due to a conflict. Should be free of conflicts now.
Hi @pitrou , I merged main again due to a conflict. Maybe you could give it another review if you have time.
> It seems that other filesystem implementations use `internal::PathFromUriHelper()`. Can we use it in Azure filesystem too? I tried that at first, but the issue is that for Azure we...
@kou Can you give it another look? I think it should be good to go.