ΘLΞG
ΘLΞG
This would be awesome! 👍 As a first step, I think it would be really helpful to verify that mentioned validation is indeed the bottleneck. Can you please exclude it...
Great, this means that we can isolate the issue and focus the effort on optimising the `OverlappingFieldsCanBeMerged` validation. Maybe you could also change the issue title to reflect this fact?...
Now that I think about it, recent bugfix introduced a change that reduces usage of the cache. i described this issue here: https://github.com/graphql/graphql-js/pull/780#pullrequestreview-49855652 This might be a promising path to...
The validation rules are normally completely self-contained. So you can just copy/paste [this old version of the validation](https://github.com/sangria-graphql/sangria/blob/5f6279b4a810b3674f53d579e43897c48de590bc/src/main/scala/sangria/validation/rules/OverlappingFieldsCanBeMerged.scala) under a different name in your test and add it in the...
Indeed, this is a concern. Assuming that parsing and `OverlappingFieldsCanBeMerged` as well as other validations are well optimized. If incoming request is allowed to have unlimited payload size, then eventually...
I see, thanks for investigating this possibility! I guess we need to look at the original algorithm and try to optimise it.
@jackandjackadswithsm Sangria is fully compliant to the most recent version of the spec. When it comes to JSON scalar type, it is not part of the spec. At the moment...
Hey Martin, this sounds great! 🙌 I think it's a great initiative! > Would something like what I am planning be possible at all in Sangria? I'm pretty sure it...
Yes, it is possible to derive a type inside of a companion object. In this case though, you probably want to derive `Picture` and `Product` independently. Unfortunately, it will not...
No unfortunately `Picture` and `Product` types need to be derived separately. Since `deriveObjectType` is a macro, it needs to know a specific derived type (so it can't be a type...