Nikolay Martyanov
Nikolay Martyanov
@christoph-zededa, don't we want to backport it to 13.4-stable? As far as it's mentioned in the discussion regarding the 13.4 LTS testing.
> For reproduction, I changed the controller handler Isn't there a way to reproduce it without changing the code? When can this situation happen in reality? I think changing code...
Just in case, I already see this: > This branch has conflicts that must be resolved
> LGTM Oh nooo, the actions were cancelled... I guess the problem is that when we leave a comment from the Review section, and it's not an Approve comment, our...
> > LGTM > > Oh nooo, the actions were cancelled... I guess the problem is that when we leave a comment from the Review section, and it's not an...
Milan, do you think we are good to merge? I saw all tests green.
Yay! Waiting for the backports now
> > As far as I see, we still use this func in another package, edgeveiew: > > @OhmSpectator yes, I will change them once this is merged and I...
> @OhmSpectator should I prepare another PR with changes to edge-view and newlog that would be merged right after this one before we merge this one? I don’t actually remember...
@europaul do we still need this PR?