Nikolay Martyanov
Nikolay Martyanov
> Let's find a time to chat. Not clear what they would want to remove (e.g., is it removing everything in /persist?) @eriknordmark, as far as I understand, they want...
@rucoder, do you think we can convert the PR into a draft for now?
Since #4394 is merged, this one is to be closed, I think.
> @OhmSpectator Greetings. I have been reviewing the modules, but this is currently limited to pillar. Just for clarify: is this the scope? Yes, sir. I meant the pillar components...
My thinking is: it’s definitely worth centralizing _directory_ path constants (like `/persist`, `/persist/log`, `/run`, etc.) into `pkg/pillar/types/locationconsts.go`. That helps with things like global cleanup logic, disk usage checks, and consistency...
I would say "thorough testing" == "Eden tests triggered in the PR are passing".
But in this case you're not only changing the documentation, you are changing code.
https://github.com/lf-edge/eve/pull/4296 https://github.com/lf-edge/eve/pull/4292
https://github.com/lf-edge/eve/pull/4287
https://github.com/lf-edge/eve/pull/4255