OgelGames

> Won't this lead people to being able to effectively grief areas which are protected? Filling up a protected spawn with bones by repeatedly killing yourself, or the like. That...

> Why don't you switch the "find nearby pos" to `may_replace()` entirely? Because that would be more complicated and I just wanted to fix this small mistake without changing too...

> @OgelGames How did #13146 fix this? This: > - Moving an item over another item now requires an additional click to swap

I think it makes sense in terms of realism; you can't just plug your drill battery into your petrol generator in real life, you need some wiring, electronics and a...

> * Double-left-clicking an item to pick up all sometimes picks up weird items. Maybe care to elaborate the rule to make testing easier? The items should be picked up...

Both, the only change I made to `client.h` was adding `m_inhibit_inventory_revert`, nothing should be removed.

Anyone know what's holding this PR up? It's been 3 months now...

I think that's everything fixed. Ready for review again. > This code gets more chaotic the more features are added to it. If it is somehow possible to split individual...

> There is a problem with the crafting using Shift when there is no more room The intended behavior is if the items can't be shifted, they are picked up...

Yeah, better to use a nice even number than something specific to a certain stack size. Also, middle click has been 10x for a long time, this PR just extended...