Florian Angeletti
Florian Angeletti
The heuristic for large modules is already selecting the first twenty components for computing a stable matching. This doesn't really have an impact on code complexity. The stable matching algorithm...
The new tests have been failing on amd64+ubuntu and arm64 on the Inria CI due to mismatched line numbers and mangling.
@tmcgilchrist , this information is available on the inria CI at https://ci.inria.fr/ocaml (on which you have access rights as far as I can see).
Personally, this looks like a sensible change after a quick look to split the archive into an archive for compiler developers and an archive for ocaml developers optimized for building...
To keep the distributed archive uniform, I think a working solution would be to exclude the same directories from all archives of the form the `ocaml-${VERSION}` and adds a `ocaml-dev-${VERSION}`...
Currently, I am planning to restart the review as soon as 5.4.0 is out.
As far as I am concerned, this is ready to merge once rebased. Did you check that the occurrence and renaming is fixed in Merlin with this patch?
I think that it might be worth it to have a last sanity check (with at least the removal of local items for aliases) before merging to avoid another iteration...
gentle ping? Should I merge in the current state?
The `-config` flags is here to introspect the configuration options used when building the compiler. It is not supposed to interact with any command line or runtime flags.