Florian Angeletti comments

Results 397 comments of


                                            Florian Angeletti

documentation: missing `since` annotations

PRs to improve documentation are always welcome. However, I am not participating as an Outreachy mentor this round, and none of the Outreachy projects are focused on the compiler either...

Make test summaries more informative

Going back to the original code for sequential and parallel join, ```ocaml let join_sequential r1 r2 = match r1, r2 with | Fail, _ | _, Fail -> Fail |...

Incorrect "type constructor ... would escape its scope"

In brief a weak type variable cannot be instantiated to a type which is defined after the type variable. In other words, for a well-typed program you should be able...

[5.3] typechecker crash while typing objects

The fatal error is from #12920 .

[5.3] Compiling C++ code using the OCaml C API results in name-mangled caml_state on Cygwin

@kit-ty-kate , is this a new failure in the beta or was the issue potentially here during the first alpha?

Use WinAPI concurrency primitives on Windows ports (remove winpthreads)

> If this PR isn't picked for this release This PR will not be picked for the 5.3 release, it is far too late for being even considered for inclusion.

Fix nontermination with `-short-paths` and recursive modules (#14036)

Thanks for the bug report and the patch! However, a suitably abstract environment is in fact available when typechecking recursive modules. You can modify the `Typedecl.check_recmod_typedecl` function to take an...

Fix nontermination with `-short-paths` and recursive modules (#14036)

Thanks a lot for the prompt update! Don't feel pressured in term of time. There is still a small tweak needed for the recursive module case. The fix for the...

Fix nontermination with `-short-paths` and recursive modules (#14036)

There are some remaining rogue newlines and overly long lines, you can have a look at https://github.com/ocaml/ocaml/blob/trunk/HACKING.adoc#check-typo to see how to run the style linter locally. Note that I am...

Fix nontermination with `-short-paths` and recursive modules (#14036)

Hm, in fact the error improvement part is a cleanly separated part of the PR. I propose to rewrite the history to have a commit for the main bug fix...