Ocean
Oh right, certainly. Here's the traceback. ``` --------------------------------------------------------------------------- ZeroDivisionError Traceback (most recent call last) in ----> 1 print(v) ~/miniconda3/envs/canary/lib/python3.8/site-packages/uncertainties/core.py in __str__(self) 1841 # string 1842 # (http://docs.python.org/2/library/string.html#format-specification-mini-language): -> 1843 return...
The wire that I'm dealing with is a BSpline curve, which means I can't use `get_intersect` without first discretizing, which makes the program equally slow anyways. (I've tried upping the...
Yeah, I kind of solved my own issue in the `ocean/csg` branch using that. I used `slice_shape()` to make `bluemira.geometry.tools.get_wire_plane_intersect`. I'll resolve/close this issue once [that branch](https://github.com/Fusion-Power-Plant-Framework/bluemira/commit/096c7e156a8ee2b042178080e2a7f3775cf3ac3a) is merged.
Furthermore, once these units are determined, the local variables inside `calc_m_release` needs to be checked to make sure that the unit conversions are done correctly.
This underlying issue seems to also plague BluemiraWire.value_at. It's worth looking into the example file I've provided. Or it could be an issue with deserialize_shape/serialize_shape.
In fact the line `coulomb_logarithm(T_e * EV_TO_J / K_BOLTZMANN, ...)` in bluemira.plasma_physics.rules_of_thumb.estimate_loop_voltage can be fixed more elegantly using `raw_uc(T_e, "eV", "K")`. This may be linked to/fixed in tandem with issue...
Note to self: while I'm solving this issue, I will also try to add ~ into all instances of `:class:` found in the docstrings, so that they are properly linked.
Just looked over it - thanks for catching this, turns out it should be dimensionless instead. Which makes more sense given that in the equation, it was being added to...
- materials - [x] material - builders - [x] tf_coils - geometry - [x] parameterisations - [x] optimisation._optimise - [x] coordinates (still needs equations for normal_vector and get_bisection_line) - [...
Closing this PR as this is replaced by #3374.