Oleg Valter

Results 86 comments of Oleg Valter

We can use an [assets preprocessor](https://guides.rubyonrails.org/v7.2/asset_pipeline.html#making-your-library-or-gem-a-pre-processor) to achieve this, methinks. Certainly a "nice to have" thing, although I don't think it should be high on our priority list as those...

> [@Oaphi](https://github.com/Oaphi) should we defer this until Rails 8.0, then? Unsure, it might be quite a while before we upgrade - if anyone wants to tackle this issue in the...

For context: the current line length limit for HTML (down from the initial limit of 150 characters per line) has first been introduced in the old wiki: https://github.com/codidact/core/wiki/Code-standards:-HTML/522d7227144463e40ef56228af578baec624c801#19-line-length

> there any objection to changing the rule to 2 spaces for all languages? No objection, that's the de-facto standard > Ruby isn't mentioned IIRC, Ruby isn't mentioned because the...

tsck, seems like mail delivery test might need better isolation (or maybe not, the pipeline only complains about the recipient's email), CircleCI didn't like the merged version at all. Initially....

> Where are you seeing that? I haven't hit that error anywhere Any attempt to manually (via the UI) sign up a user with the PR checked out - do...

> Nope, no error in manual testing or the automated tests ~~Hmm... Tests pass for me, but not the manual registration - not sure what's going on.~~ Nevermind, I think...

Leaving the coverage miss be as the logic there hasn't changed at all _and_ both cases are covered already except for the audit log creation part, which definitely hasn't changed.

> If a user can't comment (for the reasons in this PR), how is the message delivered to the user? Because it isn't since the button will no longer be...

Switching back to draft as we've decided to apply global rate limits regardless of whether the user is the post owner.