codidact
Add registration rate limit
Adds a configurable rate limit for how quickly accounts can be created from the same IP. Related to the ongoing email issues.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 66.36%. Comparing base (
51cbe3e) to head (64846ef). Report is 12 commits behind head on develop.
Additional details and impacted files
| Components | Coverage Δ | |
|---|---|---|
| controllers | 61.81% <100.00%> (+0.15%) |
:arrow_up: |
| helpers | 69.17% <ø> (ø) |
|
| jobs | 28.00% <ø> (ø) |
|
| models | 81.92% <ø> (-0.02%) |
:arrow_down: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Where are you seeing that? I haven't hit that error anywhere
Any attempt to manually (via the UI) sign up a user with the PR checked out - do you not get this error, @ArtOfCode-?
Nope, no error in manual testing or the automated tests
~~Hmm... Tests pass for me, but not the manual registration - not sure what's going on.~~
Nevermind, I think I know what's going on: there were validation errors that prevented the user from being saved. save in Devise::RegistrationsController fails, but as its return value is not handled, the user is passed back in the "dirty" state. Let's check whether the user has any errors before even trying to check the limit?