Orie Steele

Results 1091 comments of Orie Steele

> Objects are defined such that they may be used on their own or extended through [Features](https://identity.foundation/presentation-exchange/#term:features) defined subsequently in the spec. A [Feature](https://identity.foundation/presentation-exchange/#term:feature) must declare if it has dependencies...

however there are many blocks here where `additionalProperties` are false https://identity.foundation/presentation-exchange/#presentation-definition-in-an-envelope

``` "input_descriptors": [ { "id": "banking_input_1", "name": "Bank Account Information", "purpose": "We need your bank and account information.", "group": ["A"], "schema": [ { "uri": "https://bank-schemas.org/1.0.0/accounts.json" }, { "uri": "https://bank-schemas.org/2.0.0/accounts.json" }...

I am a big fan of multicodec... but I suspect that better alignment with KERI may result in a refinement on top of it. @SmithSamuelM noted on the last call...

@SmithSamuelM where is the spec for the encoding scheme KERI uses... I'm having a hard time feeling like undocumented encoding schemes are better than documented ones :) ... and multicodec...

@SmithSamuelM totally agree, can we discuss KERI / Binary / String encoding on another issue.

Cool, IMO detached JWS is the best approach for these deltas, happy to help document that in the next version of the spec.

Here is the detached JWS delta I used for my implementation: https://raw.githubusercontent.com/transmute-industries/did-peer.js/master/packages/did-peer.js/src/__fixtures__/deltas/0.json ``` { "change": "W3sib3AiOiJhZGQiLCJwYXRoIjoiL3B1YmxpY0tleS8xIiwidmFsdWUiOnsiY29udHJvbGxlciI6ImRpZDpwZWVyOjB6Nk1rZjVyR01vYXRyU2oxZjRDeXZ1SEJlWEpFTGU5UlBkem8yUEtHTkNLVnRaeFAiLCJpZCI6IiM0U1otU3RYcnA1WWQ0XzRyeEhWVENZVEh5dDR6eVBmTjFmSXVZc202azNBIiwicHVibGljS2V5SndrIjp7ImNydiI6InNlY3AyNTZrMSIsImtpZCI6IjRTWi1TdFhycDVZZDRfNHJ4SFZUQ1lUSHl0NHp5UGZOMWZJdVlzbTZrM0EiLCJrdHkiOiJFQyIsIngiOiJaNFkzTk5PeHYwSjZ0Q2dxT0JGbkhuYVpoSkY2TGR1bFQ3ejhBLTJENV84IiwieSI6Imk1YTJOdEpvVUtYa0xtNnE4bk9FdTlXT2tzbzFBZzZGVFVUNmtfTE1uR2sifSwidHlwZSI6Ikpzb25XZWJLZXkyMDIwIn19XQ", "when": "2020-06-27T18:08:28.514Z", "by": [ { "key": "#z6Mkf5rGMoatrSj1f4CyvuHBeXJELe9RPdzo2PKGNCKVtZxP", "sig": "eyJhbGciOiJFZERTQSIsImI2NCI6ZmFsc2UsImNyaXQiOlsiYjY0Il0sImtpZCI6ImRpZDprZXk6ejZNa2Y1ckdNb2F0clNqMWY0Q3l2dUhCZVhKRUxlOVJQZHpvMlBLR05DS1Z0WnhQI3o2TWtmNXJHTW9hdHJTajFmNEN5dnVIQmVYSkVMZTlSUGR6bzJQS0dOQ0tWdFp4UCJ9..zGzx3xHiN7fnejRKIvVgPUSgzzOZGs4MF5khGshaRLCRJgfD1lJpxuL0u5QZSE_Fidf5IT2pmFZwyYpHHz9wDw" } ] } ```

Current readme docs might lead users to create signatures that are note recoverable: ``` const jwt = await didJWT.createJWT( { aud: "did:example:123", exp: 1957463421, name: "uPort Developer" }, { issuer:...