Louis Sugy comments

Results 22 comments of


                                            Louis Sugy

[TF-TRT] Support resource variables (ReadVariableOp)

@gbaned This PR will be opened for review when #55337 is merged (it contains all the changes in the former).

[TF-TRT] Support resource variables (ReadVariableOp)

@tfeher @bixia1 This PR is now ready for review, since the PRs it depended on were merged.

[TF-TRT] Support resource variables (ReadVariableOp)

Thanks @tfeher for the review. I've updated the PR

[TF-TRT] Support resource variables (ReadVariableOp)

I rebased on top of master in an attempt to make CI pass

[TF-TRT] Support resource variables (ReadVariableOp)

@bixia1 Thanks for the test logs. I had forgotten in a few tests to set properly the input mask that is now required when initializing profiles. Those tests are now...

[TF-TRT] Support resource variables (ReadVariableOp)

The pylint error is in the existing code, not in my branch. See #57178

[TF-TRT] Variable converters follow-up: INT8 support and edge cases

@gbaned This PR depends on other PRs that need to be reviewed first.

[TF-TRT] Variable converters follow-up: INT8 support and edge cases

@bixia1 Following the merge of #55608, this one is now up for review.

[TF-TRT] Variable converters follow-up: INT8 support and edge cases

@bixia1 I haven't received the test logs, can you please try to send them again?

[TF-TRT] Variable converters follow-up: INT8 support and edge cases

Thanks @bixia1 for the test logs. I have fixed the test failures and solved conflicts.