Marie

Results 43 comments of Marie
trafficstars

Should i move the nginx.conf file into a docker folder? The Dockerfile should stay at the root. When it's in a subdir, it's a little bit more difficult to build...

I don't think there is really a "standard". Most repos have their Dockerfiles in the root and if there are config files, most of the time there in the root...

@axelniklasson sure! Previously maestro didn't show the output of a flow when running a single flow using the junit output format, with this change this does work. I added `--hide-execution`...

@axelniklasson / @lucaswiechmann are you sure changing this behaviour is a good idea? with this pr it's still different as it would show nothing at all, instead of the output...

@lucaswiechmann I like your suggestion, but I'm not sure if thats easily possible, as the current behaviour/output is an entirely different codepath.

I'm not interested in this anymore as we moved away from maestro. If someone else wants to pick this up, feel free to create a follow up PR.

@lucaswiechmann done!

> Could you explain a little more the motivation to update all of those dependencies to their latest version? It's good practice to keep your dependencies up to date, so...

This is not a health check, it's a mechanism to tell systemd that the application is ready (e.g. ready to accept requests), so systemd can utilize that to only start...

> Executing in the terminal and hooking via shell works? yes thats the path of my project directory, I didn't change anything in the settings