discord-data-package-explorer icon indicating copy to clipboard operation
discord-data-package-explorer copied to clipboard

Published 20 hours ago • verified publisher icon Androz2091

Add nginx configuration

Open NyCodeGHG opened this issue 4 years ago • 3 comments

This PR adds a configuration file for nginx. The history mode routing is not working correctly without this configuration. Every non-index route would be a 404 without this config.

NyCodeGHG avatar Jul 10 '21 11:07 NyCodeGHG

I'm not a regular docker user so I don't know what are the standards to store these files in a GH repository. Maybe I'm wrong and we should keep everything at root

Androz2091 avatar Jul 10 '21 11:07 Androz2091

Should i move the nginx.conf file into a docker folder? The Dockerfile should stay at the root. When it's in a subdir, it's a little bit more difficult to build correctly.

NyCodeGHG avatar Jul 10 '21 11:07 NyCodeGHG

I don't think there is really a "standard". Most repos have their Dockerfiles in the root and if there are config files, most of the time there in the root or in a config directory. But thats up to you.

NyCodeGHG avatar Jul 10 '21 11:07 NyCodeGHG