Number 3434

Results 78 comments of Number 3434

Okay, thanks! Sorry, I meant just to provide the textmate grammars, not necessarily colouring.

Would it be necessary to use semantic highlighting? Hopefully this could just use basic syntax highlighting?

Okay, but I think the suggest widget already distinguishes between fields and getter-setters. Also, in your example above, `A.a` **should** be coloured as a field (it would actually be misleading...

Personally, I would say that only declared getter-setters (i.e. **_non-implicit_**) should have a token of getter-setter. Otherwise, it should have a semantic token type of `field`. This is because, as...

@DanTup > Probably a little subjective Yeah, I agree. Since these are semantic tokens, could there be a setting to toggle this on and off?

@bwilkerson > is it more confusing to reveal to users a corner of the semantics that they frequently don't need to understand? I'm pretty sure that would be the case....

@DanTup Thanks for the link. I still think that we should colour it as the user thinks, since the semantic token colouriser is supposed to represent what the user thinks...

@bwilkerson > Unfortunately, there's no way for the tooling to know whether the reference to an induced getter-setter will be a reference to an explicitly written overriding getter-setter. Ahh, I...

Okay, maybe there could be three options: 1. Definitely a field 2. Field or getter-setter 3. Definitely a getter-setter

## To Clarify @DanTup @bwilkerson I understand your points of view. I know that it is intended to help the user better unsderstand how the Dart language works. However, is...