Noureldin
Noureldin
@tanujkhattar sure, can you assign it to me?
most optimization and inferences were implemented for the vanilla ways (as ints, lists ..etc) of defining control values, those were ported to ProductOfSums, but for SumOfProduct they didn't make sense...
@aksaw Is there progress on this? I will need this soon.
cirq-cync: proposed solution to normalize the output when we call `final_state_vector`
@smburdick thanks for volunteering to help with this, assigned to you
As per https://github.com/quantumlib/Cirq/issues/6402#issuecomment-1896371184 the decision here was to normalize the `final_state_vector`. Regardless of the precision of the type used in simulation there will always be numbers that can't be represented...
I installed the subpackages one by one, it looks like the issue comes from `cirq-rigetti` which depends on an old version of `pyquil
@ikd-sci is this for simulation or for circuit diagrams. for simulation we have the abstract class `cirq.ops.AbstractControlValues` which can be extended to represent any control function and used in simulation.
@shef4 to fix the coverage failure you need to add more tests. tests that will cover the new lines you added, specifically these lines ``` ************* cirq-core/cirq/sim/classical_simulator.py (4 uncovered) Line...
these are two different things the `state_type` is the name of the class that will store the simulation state, this type should be a subclass of `SimulationState` class. the conversation...