Tyler Dunn

Results 96 comments of Tyler Dunn

Alternatively, there is a pending PR for a switch from nw.js to Electron for the desktop client. There is a chance that might fix the resizing crash you've described. I...

Should be closed by #205 if the code is correct and jshackles merges

@richardfrost Turns out that code snippet was not actually correct. I found it on a stackexchange post and automatically assumed it was correct but such function does not exist. There...

I squashed the changes and removed a change related to my other PR to prevent conflicts between the two. @vaind Hi Ivan, is there any way you might be able...

> Thanks a lot. It looks pretty good to me, although there need to be some changes to make the code correct on Big endian machines (I know these are...

> > > Thanks a lot. It looks pretty good to me, although there need to be some changes to make the code correct on Big endian machines (I know...

> LGTM. > > Are you going to do the other lists (int32, ...) too or is this PR finished? I'll extend this to other types! I'll expand the tests...

> LGTM. > > Are you going to do the other lists (int32, ...) too or is this PR finished? For this PR specifically, it has been expanded out to...

@vaind I couldn't find out what is causing Float64List to fail, so I am going to revert the changes to the Float types and mark them with a todo to...