Tyler Dunn

Results 96 comments of Tyler Dunn

> `ByteBuffer` has an [`asInt8List`](https://api.dart.dev/stable/dart-typed_data/ByteBuffer/asInt8List.html) method along with `asUint8List`, so for symmetry perhaps a `Int8List _asInt8List(int offset, int length)` method could be added `Buffeto rContext`, and `_FbInt8List` could be removed?...

Ready for review. I tested using @tompark's example code, with the latest version of flatbuffers on pub.dev as well as this fork, and this fork prints the expected `bundle1.image1 is...

I can provide a test repo if you'd like as well, although setting up Tom's example code also takes

I applied the same changes to Int8List and Uint16List, added a missing test for Int8List and applied type checking to each test. NOTE: I changed the hex values in the...

I am extremely interested in seeing this land and would be willing to help on the review/testing. My use case isn't quite an image, but rather packed signal data that...

Should other reader classes drop their wrapped type for the dart:typed_data equivalent (eg Uint16ListReader drops _FbUint16List for Uint16List)?

https://github.com/google/flatbuffers/blob/7106d86685e3395efc6df5d2ee5914fe622ed6b9/dart/lib/flat_buffers.dart#L1207-L1213 Would it not be enough to just take this path instead of the lazy path? I don't see where it's possible to configure whether the lazy path is taken...

> To reiterate, what I'm proposing is to change `Uint8ListReader.read` and `Int8ListReader.read` to return a `Uint8List`/`Int8List` along all code paths instead of just along some of them. Currently the `lazy`...

Marked this as help needed, if anyone that is able to reproduce the issue the original ticket author had, please let me know if the linked commit helps: https://github.com/lipis/flag-icons/commit/271ab9637ff15c45dc4f61fcbca3842650a3d800

Closing this as there has been no activity. If the issue pops up again, I will look at promoting the linked commit to the main branch.