NotSoDelayed
NotSoDelayed
The following will be added in the coming hours: - Expression to get preset enchantment glint items - Condition of whether an item has enchantment glint override - TESTS!!
> It seems unnecessary to me to have an Expression, Condition, and Effect for the same thing. I think we should pick between Condition and Effect versus Expression (I think...
> I would remove the Expression and just keep the Condition/Effect combo. The effect currently sets the override to true and false. Do I need to add an additional effect...
> …. though what is the purpose of explicitly setting it to false? If the meta is set to true, the ItemStack will glint if there’s no enchantment, where vice...
The condition alone will return true if there’s an override — it could be set to either `true` or `false`. So this only tells the user that there’s an enforcement,...
Apologies for the commit spam due to test suite configuration in Gradle tasks in `skriptTestJava17` only has up to 1.20.4 somehow.
Skript’s on left/right click is based on PlayerInteractEvent and its inheritors. The user here is proposing a more ambiguous event instead.
> Tests could be added for this. You'll need to use the JUnit testing system, have a test structure to setup an ensure check and then break the block naturally...
This PR will be worked on in the coming days. EDIT: Still work in progress in JUnit tests
Staled PR — might come back in future, or being picked up by another contributor, whichever comes first.