Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Addition Effect Break Block Naturally Methods

Open NotSoDelayed opened this issue 2 years ago • 2 comments

Description

This PR allows support of new break block naturally methods from Block.class into EffBreakNaturally!


Target Minecraft Versions: any Requirements: Paper 1.15+ (effects), Paper 1.17+ (effects without tool), Paper 1.19+ (drop xps) Related Issues: -

NotSoDelayed avatar Apr 10 '23 14:04 NotSoDelayed

Tests could be added for this. You'll need to use the JUnit testing system, have a test structure to setup an ensure check and then break the block naturally in that structure. Then listen for an event that will cause the dropped item to trigger it, and mark the JUnit test as complete from that event. Not much Java code is needed, but will have to use the ensure system from the JUnit. There is a pig example currently present using the ensure system.

You can mention or message me on Discord if you need help.

JUnit tests will be added in this PR.

NotSoDelayed avatar Sep 20 '23 05:09 NotSoDelayed

This PR will be worked on in the coming days.

EDIT: Still work in progress in JUnit tests

NotSoDelayed avatar Apr 21 '24 11:04 NotSoDelayed

Staled PR — might come back in future, or being picked up by another contributor, whichever comes first.

NotSoDelayed avatar Jun 11 '24 02:06 NotSoDelayed