Results 220 comments of NotAFile

Oh, damn. That's super annoying.

IIRC, we reworked the votekick script a long time ago to prevent this exploit

Yeah, votekick uses get_player which we reworked to prevent this issue: https://github.com/piqueserver/piqueserver/blob/master/piqueserver/commands.py#L310 I don't object to the removal of newlines, although we also do some cleanup elsewhere.

The tests appear to fail because the assert you added is hit by `test_team_join`.

Hey, thanks for the fix. I think the approach I would like to see instead is to use the existing rate limiting tools that are used for other things too.

There's two things here: - By the time your character dies on your screen, you have really already been dead for ~100-300ms, depending on your latency to the server. Adding...

Sure, it's not like anyone really uses this script anyway though.

> server config shouldn't allow giving passwords for built-in roles such as `team_1`, and users should not be able to `/login team_1` Why not? I don't see any harm in...

It's hard to say exactly what's going on here since arena modifies so much stuff and you seem to be running a version with your own patches on top