Jiahao XU

Results 1312 comments of Jiahao XU

Thanks! Since there was quite some refactoring in the past release, there could be bugs, but it also could be some issues with your reader/writer doesn't provide enough data of...

It's good to hear that calling `close` fix it, sounds like our new code is catching bugs! Though I'd still want confirmation on this

That's a good idea, I'd like zstd to have an API for doing this rather than hardcoding such value though

Best solution of this is to use async drop, that would fix all the annoying problem of missing `shutdown` call rust-lang/rust#126482

> Is RAR archive format planned ? I know it's proprietary, but decompression is open source. Sometimes that's what you're given to decompress. Yes I am willing to accept PR...

> Does this mean that a tool can be implemented to install projects that support binstall without a rust environment? Yes, you could use `--disable-strategy compile` to prevent fallback to...

Yes, if there's a rust crate for 7z then I'm willing to support this

I do know there's a deflate64 that I think is somehow related to 7z, but not sure about library.

> I have not reviewed its code or tested it out, but it looks promising. Generally we want something well-maintained, and does not contain any malicious code (recent xz2 backdoor...

[`gix::discover::upwards`](https://docs.rs/gix-discover/0.20.0/src/gix_discover/upwards/mod.rs.html#194) is actually defined in crate `gix-discover`. But `gix::discover` is defined in `gix` and relies on `gix::Repository`.