Jiahao XU

Results 1312 comments of Jiahao XU

It failed because it can't find the clang shared library despite that we have installed it. https://github.com/cargo-bins/cargo-quickinstall/actions/runs/13942930943/job/39023504850 It might be that cargo-spellcheck asks for a newer clsng version that we...

`Session::close` would need to take ownership, to ensure that nothing can use it afterwards. I think you could use [`Arc::into_inner`](https://doc.rust-lang.org/std/sync/struct.Arc.html#method.into_inner) to convert `Arc` to an owned `Session`, then you could...

> So I suspected some form of error, and hence went on this route About that, I think it's time for me to add optional tracing support to log these...

> Drop the Some struct which I suspect would be dropped before the inner _session is dropped -- somehow none of these work, i.e. they end up with a none/error...

> Are the functions such as close, disconnnect, etc. purposefully built to take ownership of self? If not, can we take references instead? @CowBoy4mH3LL yes, that's definitely possible! TBH, openssh...

> BTW -- does the child automatically disconnect when it goes out of scope? i.e. say I execute commands in a loop and each call execution is performed in a...

IMO it's probably because the inline repr, where the first character can be `\0`.

> My question was really: Does it matter that `HeapBuffer` and `StaticStr`'s use of `NonNull` doesn't match with `Repr`, which they get transmuted to? Hmmm yeah it gets ignored currently,...

> But there is still one weird case where 0 is valid bit pattern for all of 1st 8 bytes: `CompactString::new("\0\0\0\0\0\0\0\0")`. I think that rules out using `NonNull` in `Repr`....

> so tools like miri can check provenance. This reminds me of a problem: with arm CHERI, size of pointer is 128 bits instead of 64 bits, containing an extra...