NoPenguinsLand

Results 18 comments of NoPenguinsLand

> I don't think that we need the new `deviations_` attribute since it is not used during the prediction phase. Nearest Centroid classifier has a really neat property of simultaneously...

I'm leaving `self.deviations_` attribute for now. Just let me know if you still don't think it's necessary and I can change it to `deviations_`

> > I'm leaving self.deviations_ attribute for now. Just let me know if you still don't think it's necessary and I can change it to deviations_ > > I did...

> Yep but I would not add it in his pull-request but rather in a subsequent one. Sounds good! Should we update this one? https://scikit-learn.org/stable/auto_examples/neighbors/plot_nearest_centroid.html#sphx-glr-auto-examples-neighbors-plot-nearest-centroid-py

@glemaitre what's the status of this PR? Will this get merged soon? I would appreciate any transparency and specific details. If there's any issues or unfinished works, please let me...