NoPenguinsLand

Hey Stephen, happy to help! I added multiple functionalities, do you mean to break them down in separate functions (which is rather hard to separate them) or just rename the...

It's possible but all of these functionalities are intimately tied to GLM calculations so I personally think it's best to leave it as is, plus it will run faster when...

@kempa-liehr would you like to finish this or leave it to a new contributor?

@adrinjalali can you please review this when you get a chance?

@glemaitre Left comments on two issues, but everything else, OK. Thank you for taking the time to review this.

Thanks for the feedback! One issue that's breaking the pytest's testing is the lack of support for sparse arrays. Should I add (more) support for sparse arrays?

@glemaitre the codes are ready for review. Regarding argmax vs argmin definitions, `LinearDiscriminantAnalysis` and `QuadraticDiscriminantAnalysis` are using the argmax definition and since we're calling __from_discriminant_score_to_probability_ function in both `QuadraticDiscriminantAnalysis` and...

> > to keep things simple, I think argmax is best. > > But we don't have any `pairwise_distance_argmax` function if I am not wrong. Nor do we need it....

@glemaitre the codes are ready for review.

In pytest, there should be a problem with the `check_estimators_dtype` function, particularly with `X_train_int_64` and `X_train_int_32` inputs. It should raise ValueError due to a zero in `self.within_class_std_` in order to...