Nityanand Rai

Results 23 comments of Nityanand Rai

@rgarrigue I am not able to reproduce the error. So can you please share the steps to reproduce this error?

> Could you post a video on how to use this new change? Something like this so it's easier to QA. > > [#863 (comment)](https://github.com/mattermost/mattermost-plugin-jira/pull/863#issuecomment-1200475963) > > Thank you! Vedio...

> Can't see the video, could you please check if you can upload a compatible format with Drive? Thank you @Nityanand13 ! Vedio link for this PR: [Fixed_Issue_Jira_autolink_should_support_issue_links_that_contain_a_comment_link_in_the_URL.webm](https://user-images.githubusercontent.com/107465508/194277231-c36f4754-7f25-434b-afeb-454d2a131430.webm) I think...

> @Kshitij-Katiyar I'm thinking we should have tests in the autolink repo to test these regex changes, like [mattermost/mattermost-plugin-autolink#189](https://github.com/mattermost/mattermost-plugin-autolink/pull/189). Please let me know your thoughts on this +1 @mickmister Test...

> > > You need to rebase, this branch has commits from master. > > > > > > @javaguirre In general I try to discourage rebasing for open PRs,...

> @javaguirre Sorry for the late reply. Your approach seems good and now I am implementing the same.

> Could you post a video on how to use this new change? Something like this so it's easier to QA. > > [#863 (comment)](https://github.com/mattermost/mattermost-plugin-jira/pull/863#issuecomment-1200475963) > > Thank you! Vedio...

> @Nityanand13 Can't open the videos in any of the PRs, can you check the extension of the files and tell me what kind of video is so I can...

> That is a very nifty feature tada > > One broad question before I dive into the code too much: The implementation currently uses a custom post and a...

@asatkinson Is it reasonable to send the notification in the replies once we make a comment or close an issue? ![temp](https://user-images.githubusercontent.com/107465508/208690483-7b6e4ebb-acb9-413a-bada-8f23c8b72a04.png)