Nima Sarajpoor

@seanlaw Done! (Thanks for the challenge!)

A few things got my attention after taking a look at the paper/code. Going to share it to just highlight it for future readers: (1) The paper proposes an algorithm...

@joehiggi1758 Great work on implementing many algorithms including the ones referenced and used in the paper!! A few things got my attention as I was going through your notebook. I...

A [similar error was observed](https://github.com/TDAmeritrade/stumpy/actions/runs/14301137269/job/40075680424?pr=1068) for `m=9, s=3, k=3`. ``` OS: MacOS python=3.12 numpy=2.1.3 numba= 0.61.0 llvm=0.44.0 ``` And the error is: ``` _______________ test_mpdist_snippets_s_with_isconstant[3-3-9-T0] _______________ T = array([ 293.67128677,...

> Do we know why this is happening? According to my investigation, I think the issue is coming from naive. In the naive snippet, a loss of precision occurs when...

I updated [my previous comment](https://github.com/TDAmeritrade/stumpy/issues/1061#issuecomment-2783969600) and expanded the response. In short, the issue is a loss of precision that occurs in `np.sum` in this line: https://github.com/TDAmeritrade/stumpy/blob/423c679fdfcdd547744d2b9a2aed7565124fd6e1/tests/naive.py#L1617 A small loss of...

Right! I am now thinking what if we just avoid setting fastmath here for core._mass because this function does not do any arithmetic operations. I can try it out and...

In the following, `A --> B` means function `A` calls function `B`. ``` # in stumpy.core mass --> _mass _mass --> calculate_distance_profile calculate_distance_profile --> _calculate_squared_distance_profile _calculate_squared_distance_profile --> _calculate_squared_distance ``` I...

> This means that fastmath=True is "wrong". I would simply make every level of the nested function calls fastmath={"nsz", "arcp", "contract", "afn", "reassoc"}. That would be my preference as this...

Right! I will take a closer look (Also, I want to see what happens to `T_subseq_isconstant` when a subsequence is all `np.nan`)