Nima Sarajpoor
Nima Sarajpoor
@lwasser > do you not have permissions to change labels? you are on the team! Apparently I do now! I did not check it again after the second time! I...
@seanlaw I think, as our first step, a scrip that just gives us that list above should be helpful. Basically, the script can search for `fastmath=True`, and for any of...
**[Update]** After some research, I came up with the following code that can get the callers and the callee(s) in a script. ``` import ast def _visit_all_child_nodes(node, lst): for n...
> 1. Maybe instead of `lst = []`, call it something like `all_functions = []` > 2. What happens to your script when the caller and callee chain are in...
@seanlaw I looked at `docstring.py` and borrowed the following parts to detect functions/methods : https://github.com/TDAmeritrade/stumpy/blob/b7b355ce4a9450357ad207dd4f04fc8e8b4db100/docstring.py#L77-L85 https://github.com/TDAmeritrade/stumpy/blob/b7b355ce4a9450357ad207dd4f04fc8e8b4db100/docstring.py#L91-L96 --- The new version of my script (provided below) goes through each file and...
> Next step is to revise the script above to check for fastmath flag as well when is_njit is True, and include that in the output. @seanlaw Since we are...
@seanlaw > If there is sufficient overlap with docstring.py then we should also consolidate and refactor if it makes sense > It feels like we are starting to accumulate scripts...
> @NimaSarajpoor Things look fine. However, for the two examples that you provided, I don't like that the outputs are allowed to be of different type. Specifically, I expect Example...
> I noticed that your original list did not contain functions like core._get_array_ranges or core._get_ranges or core._merge_topk_PI (and many others). Correct. Currently, the NJIT functions without fastmath are: ``` #...
Going to close this one as the work is now tracked in PR #1068