Colin Kennedy
Colin Kennedy
[message.From = *e.store.GetAddress()](https://github.com/statechannels/go-nitro/blob/a372a29f12f645bb4ba2f4869f72fb11ecc2c5e1/client/engine/engine.go#L572) Implementation dependant, but I believe current buntdb implementation does a read from disk on each lookup like this. This function is part of delivering a voucher, so...
In 5319623e, an RPC method was fixed. Prior to the fix, the method was failing without providing much useful feedback.
The gas metrics scripts are great. Relatively low friction for good data recording on metrics we care about. A missing piece is being able to easily view what these metrics...
Did you mean to include this? Would it be better to file an issue? _Originally posted by @geoknee in https://github.com/statechannels/go-nitro/pull/1322#discussion_r1229489534_ Updating gas results is a 'final step' in any changes...
Core protocol contracts (eg, Adjudicator.sol) currently live side-by-side with application channel contracts (eg, VirtualPaymentApp.sol, TrivialApp.sol). Also there is an `examples` directory containing HashLockedSwap.sol, SingleAssetPayments.sol. Probably wants for a cleanup.
All public api methods for moving funds _out_ of a channel currently `_requireChannelFinalized`. This prevents partial checkouts. Partial checkouts are an important piece to permit lowest-cost happy path nitro, where...
PR replaces `A word of costs 512 gas` with `A word of calldata costs 512 gas`.
for a highlighted item: - press `t` - a drop list of known tags appears - either - up/down, enter to select, or - type to fuzzy filter or create...
I'm less than 100% on the details here, but I think this at least ballpark correct: - these examples use chessgounnd - there are some api / type changes between...