go-nitro icon indicating copy to clipboard operation
go-nitro copied to clipboard

console.log a summary of changed gas results for a commit message

Open NiloCK opened this issue 2 years ago • 0 comments

          Did you mean to include this? Would it be better to file an issue?

Originally posted by @geoknee in https://github.com/statechannels/go-nitro/pull/1322#discussion_r1229489534

Updating gas results is a 'final step' in any changes to on-chain code. It'd be nice if the commits with these updated values included a summary of any significant changes - something like:

updated gas results...

...
directlyFundAChannelWithETHSecond increased by 3%
...

Maybe 0.5% is a cutoff for what's considered significant.

NiloCK avatar Jun 15 '23 14:06 NiloCK