nikaple

Results 9 comments of nikaple

没有理解为何这么做就可以修复你所说的问题,参考: #81

如果确认可以修复这个问题的话,麻烦在 e2e/fixture 文件夹下补充一下对应的用例~ 刚在本地试了下目前的代码并不能修复你提出的问题

In order to avoid breaking changes, I'd suggest make this feature opt-in by adding another optional property to `FileLoaderOptions`, such as `allowUndefinedEnvironmentVariables`. PRs are welcome.

Please provide an minimum reproduction repo to help better investigation.

@waptik You should use arrow functions. See: https://typescript-eslint.io/rules/no-this-alias/

@MissCuriosity GetValue, GetBase以及Reference类型等这篇文章提到的概念都属于浏览器底层的实现,只是为了从原理上来解读this指向问题的,自然在console里是无法使用的~

Thanks for reviewing! Is there any chances that these changes could be released?

Thanks for invitation! Since translations are all processed with tolgee, I guess this PR could be closed?

Yeah, there's some workaround and I'm using a set-based method which is `O(n)`. Just curious if the library author is willing to fix this, as it's a breaking change.