Nihar Phansalkar
Nihar Phansalkar
The request was to add a `checked` attribute to the buttons and create a legend. However, I personally feel that a `required` attribute is the best and the cleanest way...
I am extremely sorry for the mistakes. Thank you for being patient with me.
@bbsmooth I have made the required changes. I changed all `required` into `checked` and also added in the legend. Please re-review the PR.
Sure, I will look into it over the weekend and make the required changes. 👍
I want to ask what kinds of tests can be written for this fix? The actual problem was occuring for frameworks such as Jest. Native code works just fine.
The test for this is already being covered in the following: https://github.com/nodejs/node/blob/ba957a61f83365d9df7126c23a1c78c320061414/test/parallel/test-assert.js#L50C5-L50C46 Where if the code is now run with Jest, instead of an `AssertionError`, the provided error will be...
I am a little confused @apapirovski. If you go through the discussion of the issue, you can see that the problem was never with NodeJS directly. The code was working...
@apapirovski Thank you so much for everything
@BridgeAR I will make the changes, however can you please tell me if I am able to understand the reason for this? My current commit, it checks for e to...
@DavidJDallas Hello, I am a little confused. In order to work out a solution for this feature, will I have to modify the files present in `/lib/cancel`? If yes, I...