Eric Cochran

Results 17 comments of Eric Cochran
trafficstars

Is there an existing ticket to get these methods added to the Android SDK itself? Does this belong in a different support library like v4 compat?

Nobody should be importing java.util.LinkedList lol.

truuuuue. (feel free to close if this isn't the right place for a best practices request. looking forward to that!)

One notable exception is lambdas. Lambdas are a higher priority for being last in the parameter list. `fun foo(unused: Any? = null, a: (String) -> Unit) {}` `foo {}` works...

The JetBrains style guide (https://kotlinlang.org/docs/reference/coding-conventions.html) likes the second. (I've come to like it as well.)

The minSdkVersion is 26 (Android O), as stated in the README. You aren't supposed to able to install it on N.

This would be great for Kotlin or Java as well!

FWIW, I always `Intent.setPackage("com.android.vending")` to be safe when directing to the Play Store.

This seems odd because the doc for [`Intent.EXTRA_TEXT`](http://developer.android.com/intl/es/reference/android/content/Intent.html#EXTRA_TEXT) clearly says a CharSequence should be expected. It looks like something something was expecting an ArrayList. Do you have info about the...

I don't think it looks like AOSP at all. Somewhere, modified sample code or something is calling `getCharSequenceArrayList(Intent.EXTRA_TEXT)`, and the call will just return null after failing the cast. Needs...