Nicolas Hug

Results 570 comments of Nicolas Hug

Sure, happy for you to take over @betatim , thanks!

What followed from the aforementioned comment is https://github.com/scikit-learn/scikit-learn/pull/15105 (closed, but can be re-opened). Also related: these notes on how warm-starting within a grid search is fundamentally different from warm-starting within...

Thanks for taking care of the benchmarks. I think it's fine to delete whatever is here and for you to push directly. Should we rename `sciki-learn-speed` into `scikit-learn-benchmarks`? Since we...

@abhi8893 thank you so much for putting out this PR @rodrigc thank you so much as well for your previous PR and for reviewing this one. I've pushed a bunch...

Thanks all for the reports. This should hopefully be fixed by @stefan-baumann 's https://github.com/pytorch/vision/pull/8548. This will be available in the next version within a few months.

As a hack, can you check if the build works if you change the extension of all the `.c` files in https://github.com/pytorch/vision/tree/main/torchvision/csrc/io/image/cpu/giflib into `.cpp` (with MACOSX_DEPLOYMENT_TARGET=11.0)

Hi folks. Looks like the mac compiler is unhappy compiling C files while passing C++ flags, while the other compilers just ignore the flags. Perhaps the fix just a matter...

That part hasn't been updated in a while, there's a good chance it's not needed anymore or needs to be updated!

Thanks for the PR @joshestein . Unfortunately we cannot add these type annotations because they would break torchscript support, which is a required feature of these functions. That being said,...

Thanks for the PR @real-ojaswi . This was already partly addressed in https://github.com/pytorch/vision/pull/8368 but that PR was stalled. Yours was good too but a few changes were necessary - since...